[Lldb-commits] [PATCH] D61776: [Target] Generalize some behavior in Thread

[Alex Langford via Phabricator via lldb-commits]

xiaobai added a comment.

Unfortunately I can't land this patch as-is. With this patch applied, TestObjCExceptions fails. It looks like c++ exceptions are supported at the bare minimum as a part of the objc exception handling logic.

It was failing 2 subtests: `test_objc_exceptions_at_throw` and `test_cxx_exceptions_at_abort`. The first test was failing because of a minor bug that I will include a fix for in this patch. The second test is failing because of an assertion that the current exception we get should not be valid, but now it is valid. That is because we are able to get the exception object from the C++ runtime now. However, the assertion that the exception backtrace isn't valid still holds (since that isn't implemented for C++). I'm going to update this patch to reflect this new information in the near future and then request another review from y'all.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61776/new/

https://reviews.llvm.org/D61776