[Lldb-commits] [PATCH] D61752: Re-enable a test for non-Windows
Stella Stamenova via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu May 9 12:30:08 PDT 2019
stella.stamenova requested changes to this revision.
stella.stamenova added inline comments.
This revision now requires changes to proceed.
Comment at: lldb/lit/Breakpoint/case-sensitive.test:1
-# REQUIRES: nowindows
+# UNSUPPORTED: windows
This should be system-windows. See config.py in llvm. By using system-windows, the test would be consistent with other platforms. Incidentally, I am just about to fix this as well as the test in LLVM that you changed to use windows - it should also use system-windows.
Comment at: lldb/lit/lit.cfg.py:101
+# Allow distinguishing Windows host from others.
+if sys.platform.startswith('win') or sys.platform.startswith('cygwin'):
This really should live in config.py in llvm so that it can be used across all projects. And it should be system-windows for consistency with other platforms.
CHANGES SINCE LAST ACTION
More information about the lldb-commits