[Lldb-commits] [PATCH] D61686: Enable lldb-server on Windows

Wed May 8 12:48:18 PDT 2019

amccarth marked an inline comment as done.
amccarth added inline comments.

================
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:220
+    // In most cases the missing notifications do not affect lldb-server
+    // so we are temporarily relaxing the following for Windows.
+#if !defined(_WIN32)
----------------
Hui wrote:
> amccarth wrote:
> > What's the scope of "temporarily"?  Is there some specific feature or change that will cause this workaround to be removed?
> Currently the absence of pty support is treated as a fatal error that will block the overall usage of lldb-server.exe for windows. In my opinion, the redirection of std -i/o/e are mainly intended to generate I* and O* packets to notify the lldb about the llgs's inferior (shown on lldb console). Without such support, some of the lldb-server functionalities, like launch/attach process and most of the remote packets etc. still can be tested or say be experimented (see the python tests under tools/lldb-server). 
> 
> Temporarily relax the mentioned codes and wait  for the pty support on windows. No concrete idea how to add that support now.
Got it.  I misunderstood the original comment and thought the "temporarily" applied to the code change itself.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61686/new/

https://reviews.llvm.org/D61686