[Lldb-commits] [PATCH] D61648: [DWARF] Centralize user_id <-> DWARFDIE conversions

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed May 8 04:41:45 PDT 2019


labath marked 3 inline comments as done.
labath added inline comments.


================
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h:138-139
+  DWARFDIE GetDIEFromUID(lldb::user_id_t uid);
+  lldb::user_id_t GetUIDFromDIE(DWARFBaseDIE die);
+  lldb::user_id_t GetUIDFromDIERef(DIERef ref);
 
----------------
clayborg wrote:
> Maybe just overload these?:
> ```
> lldb::user_id_t GetUID(DWARFBaseDIE die);
> lldb::user_id_t GetUID(DIERef ref);
> ```
Sounds good.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61648/new/

https://reviews.llvm.org/D61648





More information about the lldb-commits mailing list