[Lldb-commits] [PATCH] D61648: [DWARF] Centralize user_id <-> DWARFDIE conversions
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue May 7 12:33:11 PDT 2019
labath created this revision.
labath added reviewers: JDevlieghere, clayborg, aprantl.
The logic for translating a user_id into a DWARFDIE was replicated in
several places. This removes that redundancy and settles on a single
implementation in SymbolFileDWARF.
The reason for choosing that instead of DIERef was that we were
always immediately converting the returned DIERef into a DWARFDIE
anyway, which meant that one had to specify the SymbolFileDWARF argument
twice (once to get the DIERef, and once to get the actual DIE). Also,
passing a higher-level object (SymbolFileDWARF) into a lower-level one
(DIERef) seemed like a less intuitive arrangement than doing things the
other way around.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 12211 bytes
Desc: not available
More information about the lldb-commits