[Lldb-commits] [PATCH] D61481: [DWARF] Reimplement/simplify DWARFUnit::GetID

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon May 6 00:36:11 PDT 2019


labath marked 2 inline comments as done.
labath added inline comments.


================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h:43
   size_t GetNumCompileUnits();
   DWARFUnit *GetCompileUnitAtIndex(uint32_t idx);
+  DWARFUnit *GetCompileUnitAtOffset(dw_offset_t cu_offset,
----------------
JDevlieghere wrote:
> This should probably take a `lldb::user_id_t` then?
Yep, I guess it should.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61481/new/

https://reviews.llvm.org/D61481





More information about the lldb-commits mailing list