[Lldb-commits] [PATCH] D61579: Propagate command interpreter errors from lldlbinit

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Sun May 5 19:37:21 PDT 2019


JDevlieghere created this revision.
JDevlieghere added reviewers: clayborg, labath, jingham.
Herald added a subscriber: abidh.
Herald added a project: LLDB.
JDevlieghere added a parent revision: D61578: [Driver] Add command line option to allow loading local lldbinit file.

This patch ensures that we propagate errors coming from the lldbinit file trough the command/script interpreter. Before, if you did something like `command script import syntax_error.py`,  and the python file contained a syntax error, lldb wouldn't tell you about it. This changes with the current patch: errors are now propagated by default.

PS: Jim authored this change and I added testing.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D61579

Files:
  lldb/include/lldb/Interpreter/CommandInterpreter.h
  lldb/lit/Driver/Inputs/.lldbinit
  lldb/lit/Driver/Inputs/syntax_error.py
  lldb/lit/Driver/LocalLLDBInit.test
  lldb/source/Breakpoint/BreakpointOptions.cpp
  lldb/source/Commands/CommandObjectBugreport.cpp
  lldb/source/Commands/CommandObjectCommands.cpp
  lldb/source/Commands/CommandObjectSettings.cpp
  lldb/source/Commands/CommandObjectWatchpointCommand.cpp
  lldb/source/Interpreter/CommandInterpreter.cpp
  lldb/source/Target/Target.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61579.198215.patch
Type: text/x-patch
Size: 10039 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190506/e82992c6/attachment-0001.bin>


More information about the lldb-commits mailing list