[Lldb-commits] [PATCH] D61481: [DWARF] Reimplement/simplify DWARFUnit::GetID

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

LGTM with one inline comment.



================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h:43
   size_t GetNumCompileUnits();
   DWARFUnit *GetCompileUnitAtIndex(uint32_t idx);
+  DWARFUnit *GetCompileUnitAtOffset(dw_offset_t cu_offset,
----------------
This should probably take a `lldb::user_id_t` then?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61481/new/

https://reviews.llvm.org/D61481