[Lldb-commits] [PATCH] D61473: ExpressionParser: only force link MCJIT when needed
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri May 3 03:00:41 PDT 2019
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
Did you run the test suite with this change? I get about 200 failures (non-shlib build), which is not surprising as without this lldb will not actually have a jit engine to evaluate the expressions with.
The best thing to do here would be make sure lldb-server never even pulls the ClangExpressionParser library into its dependency graph, but in the current state of the graph, that would likely take the rest of this year. So given the simplicity of this change, and the amount of code it saves us, I think we could settle for something slightly sub-optimal, but which will still produce the desired effect.
What I propose is to move this header into the SystemInitializerFull class. That should still result in MCJIT being linked into liblldb (as it should be), but exclude it from lldb-server. The SystemInitializerFull class is a slightly odd place for this, but *only* slightly, because it's where we do the rest of llvm initialization (`llvm::InitializeAllTargets()` and friends), and the nature of this header is very initialization-like.
CHANGES SINCE LAST ACTION
More information about the lldb-commits