[Lldb-commits] [PATCH] D61451: Hide runtime support values such as clang's __vla_expr from frame variable
Adrian Prantl via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu May 2 12:22:30 PDT 2019
aprantl added a comment.
In D61451#1488186 <https://reviews.llvm.org/D61451#1488186>, @jingham wrote:
> Could you add a comment (probably best in LanguageRuntime.h) saying what a RuntimeSupportValue is?
> Also, so far as I can tell, this patch works because we use the CPP language runtime for C++ methods is an ObjC++ file, and the ObjCLanguageRuntime for ObjC methods in ditto. That is surely the right thing to do, but it would be good to ensure that there's a test that asserts this behavior. I'm sure there must be but didn't see on a quick scan. Can you make sure there's such tests and if not add one?
I'm not sure what exactly you want me to test there. Can you elaborate?
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits