[Lldb-commits] [PATCH] D61361: PluginInstructionARM: avoid unnecessary link

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

I don't think this is a good way to solve this problem. The llvm's definition of dependencies http://llvm.org/docs/CodingStandards.html#library-layering explicitly that it is not the same as "the thing that's needed to make linkers happy" (emphasis mine):

  One library (both its headers and implementation) should only use things from the libraries listed in its dependencies.
  
  ***Some*** of this constraint can be enforced by classic Unix linkers...
  
  This doesn’t fully enforce all inter-library dependencies, and importantly doesn’t enforce header file circular dependencies created by inline functions. A good way to answer the “is this layered correctly” would be to consider whether a Unix linker would succeed at linking the program if all inline functions were defined out-of-line...

I am guessing that you the reason for this dependency is the headers defining various register constants. A good way to solve that would be to create a new library, and move all the headers of this kind there...


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61361/new/

https://reviews.llvm.org/D61361