[Lldb-commits] [PATCH] D61064: Object/Minidump: Add support for the ThreadList stream

[Pavel Labath via Phabricator via lldb-commits]

labath marked 2 inline comments as done.
labath added a comment.

Thanks for the review.



================
Comment at: unittests/Object/MinidumpTest.cpp:446
+
+  for (const std::vector<uint8_t> &Data : {OneThread, PaddedThread}) {
+    auto ExpectedFile = create(Data);
----------------
jhenderson wrote:
> I missed this in the other tests, but this could be an `ArrayRef<uint8_t>` instead of a `const std::vector<uint8_t> &`. Feel free to leave it as is or to update it in an NFC throughout this test afterwards, if you would prefer to leave it to another patch.
There's just one more test besides this one, so I'll update everything in this patch.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61064/new/

https://reviews.llvm.org/D61064