[Lldb-commits] [PATCH] D61183: PostfixExpression: Introduce CFANode

[Pavel Labath via Phabricator via lldb-commits]

labath marked an inline comment as done.
labath added inline comments.


================
Comment at: source/Symbol/PostfixExpression.cpp:150
+  /// InitialValueNodes in our input expression, we assume the initial stack
+  /// will contain their value (hence we start with m_stack_depth = 1). If we
+  /// don't have InitialValueNodes, this value is not used, and so its starting
----------------
amccarth wrote:
> I'm having trouble understanding this comment.
> 
> "will contain their value" -- What does "their" refer to here?  I guessed InitialValueNodes, but then I'd expect "value" to be "values" (plural), and I'm not sure how that relates to the stack depth.
I've rephrased this so that it is (hopefully) more understandable. The reason for the singular-plural schism is that the expression can theoretically contain multiple InitialValueNodes (I'm not sure why would anyone want to do that in practice, but the option is there), but they will all refer to the same value, which is the value pushed onto the dwarf stack before the expression evaluation began.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61183/new/

https://reviews.llvm.org/D61183