[Lldb-commits] [PATCH] D61235: Add more information to the log timer dump
António Afonso via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Apr 29 11:56:27 PDT 2019
aadsm marked an inline comment as done.
aadsm added inline comments.
Comment at: lldb/unittests/Utility/TimerTest.cpp:100-101
+ << "String: " << ss.GetData();
+ EXPECT_GT(total1 - child1, seconds1 - 0.001);
+ EXPECT_LT(total1 - child1, seconds1 + 0.001);
+ EXPECT_EQ(1, count1);
> aadsm wrote:
> > davide wrote:
> > > this seems ... very fragile.
> > that's a good point. I'm not that familiar with the ieee754 to know what's a safe interval here, do you know?
> I think you want to use `EXPECT_DOUBLE_EQ` here.
It still doesn't help me :(
Expected: total1 - child1
Which is: 0.099999999999999992
To be equal to: seconds1
Which is: 0.10011115499999999
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits