[Lldb-commits] [PATCH] D61244: Re-enable gmodules tests on Linux

[Raphael Isemann via Phabricator via lldb-commits]

teemperor created this revision.
teemperor added a reviewer: labath.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
teemperor edited the summary of this revision.

These tests are not failing for me on (Arch) Linux, so I would suggest that we re-enable them. See also http://llvm.org/pr36107 which is the reason we disabled them.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D61244

Files:
  lldb/packages/Python/lldbsuite/test/lang/cpp/gmodules-templates/TestGModules.py
  lldb/packages/Python/lldbsuite/test/lang/cpp/gmodules/TestWithModuleDebugging.py


Index: lldb/packages/Python/lldbsuite/test/lang/cpp/gmodules/TestWithModuleDebugging.py
===================================================================
--- lldb/packages/Python/lldbsuite/test/lang/cpp/gmodules/TestWithModuleDebugging.py
+++ lldb/packages/Python/lldbsuite/test/lang/cpp/gmodules/TestWithModuleDebugging.py
@@ -9,7 +9,6 @@
 
     mydir = TestBase.compute_mydir(__file__)
 
-    @skipIf(bugnumber="llvm.org/pr36146", oslist=["linux"], archs=["i386"])
     @add_test_categories(["gmodules"])
     def test_specialized_typedef_from_pch(self):
         self.build()
Index: lldb/packages/Python/lldbsuite/test/lang/cpp/gmodules-templates/TestGModules.py
===================================================================
--- lldb/packages/Python/lldbsuite/test/lang/cpp/gmodules-templates/TestGModules.py
+++ lldb/packages/Python/lldbsuite/test/lang/cpp/gmodules-templates/TestGModules.py
@@ -1,6 +1,3 @@
 import lldbsuite.test.lldbinline as lldbinline
-from lldbsuite.test.decorators import *
 
-lldbinline.MakeInlineTest(__file__, globals(), [
-    expectedFailureAll(oslist=["linux"], bugnumber="llvm.org/pr36107",
-        debug_info="gmodules")])
+lldbinline.MakeInlineTest(__file__, globals())


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61244.197034.patch
Type: text/x-patch
Size: 1215 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190428/c034c89b/attachment.bin>