[Lldb-commits] [PATCH] D61235: Add more information to the log timer dump

[Raphael Isemann via Phabricator via lldb-commits]

teemperor added a comment.

Could you provide a test? There are some existing tests for Timer in `lldb/unittests/Utility/TimerTest.cpp` which you can extend. You can run/compile these tests via `LIT_FILTER="TimerTest" make check-lldb`.

(I also believe this patch breaks `TimerTest` as it checks the output of `DumpCategoryTimes`)



================
Comment at: lldb/source/Utility/Timer.cpp:111
 
-typedef std::pair<const char *, uint64_t> TimerEntry;
+struct Stats {
+  uint64_t nanos;
----------------
Can you move struct this into an anonymous namespace?


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61235/new/

https://reviews.llvm.org/D61235