[Lldb-commits] [PATCH] D61172: [ScriptInterpreter] Pass the debugger instead of the command interpreter
Jim Ingham via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Apr 26 10:29:22 PDT 2019
jingham added a comment.
Looks good to me too. The fact that you were mostly eliminating redirections from CommandInterpreter -> Debugger is good evidence this was wrongly structured initially.
I'm a little curious that we do:
to read "break command add -s python" command text. Seems like the script interpreter IO handler should do this otherwise the Command Interpreter has to know the right way to do input for every script interpreter. But I think that's a change for another patch.
This one seems pure goodness.
CHANGES SINCE LAST ACTION
More information about the lldb-commits