[Lldb-commits] [PATCH] D61182: DWARFExpression: Fix implementation of DW_OP_pick
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Apr 26 04:17:31 PDT 2019
labath created this revision.
labath added reviewers: jasonmolenda, clayborg.
Herald added subscribers: aprantl, mgorny.
The DWARF spec states that the DWARF stack arguments are numbered from
the top. Our implementation of DW_OP_pick was counting them from the
This bug probably wasn't noticed because nobody (except my upcoming
postfix-to-DWARF converter) uses DW_OP_pick, but I've cross-checked with
gdb to confirm that counting from the top is the expected behavior.
This patch fixes the implementation to match the spec and gdb behavior
and adds a test.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 3890 bytes
Desc: not available
More information about the lldb-commits