[Lldb-commits] [PATCH] D61128: Fix stack unwinding for struct methods

Adrian McCarthy via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Apr 25 17:18:51 PDT 2019


amccarth added a comment.

Please add some detail to the commit message and consider re-titling it.  It looks like this patch is actually adding missing functionality rather than "fixing" a bug in how structs are handled.  If that's correct, then please make the commit message reflect that.

Sorry I didn't get a chance to finish reviewing this today, but I'll try to get it done tomorrow.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61128/new/

https://reviews.llvm.org/D61128





More information about the lldb-commits mailing list