[Lldb-commits] [lldb] r359234 - Two tests were using the interactive convenience variable

Jason Molenda via lldb-commits lldb-commits at lists.llvm.org
Thu Apr 25 13:03:40 PDT 2019


Author: jmolenda
Date: Thu Apr 25 13:03:39 2019
New Revision: 359234

URL: http://llvm.org/viewvc/llvm-project?rev=359234&view=rev
Log:
Two tests were using the interactive convenience variable
lldb.debugger.  They should not be.
<rdar://problem/50210340> 

Modified:
    lldb/trunk/packages/Python/lldbsuite/test/expression_command/issue_11588/Test11588.py
    lldb/trunk/packages/Python/lldbsuite/test/macosx/thread-names/TestInterruptThreadNames.py

Modified: lldb/trunk/packages/Python/lldbsuite/test/expression_command/issue_11588/Test11588.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/expression_command/issue_11588/Test11588.py?rev=359234&r1=359233&r2=359234&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/expression_command/issue_11588/Test11588.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/expression_command/issue_11588/Test11588.py Thu Apr 25 13:03:39 2019
@@ -48,7 +48,7 @@ class Issue11581TestCase(TestBase):
         # register r14 is an x86_64 extension let's skip this part of the test
         # if we are on a different architecture
         if self.getArchitecture() == 'x86_64':
-            target = lldb.debugger.GetSelectedTarget()
+            target = self.dbg.GetSelectedTarget()
             process = target.GetProcess()
             frame = process.GetSelectedThread().GetSelectedFrame()
             pointer = frame.FindVariable("r14")

Modified: lldb/trunk/packages/Python/lldbsuite/test/macosx/thread-names/TestInterruptThreadNames.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/macosx/thread-names/TestInterruptThreadNames.py?rev=359234&r1=359233&r2=359234&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/macosx/thread-names/TestInterruptThreadNames.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/macosx/thread-names/TestInterruptThreadNames.py Thu Apr 25 13:03:39 2019
@@ -30,11 +30,11 @@ class TestInterruptThreadNames(TestBase)
 
         launch_info = lldb.SBLaunchInfo(None)
         error = lldb.SBError()
-        lldb.debugger.SetAsync(True)
+        self.dbg.SetAsync(True)
         process = target.Launch(launch_info, error)
         self.assertTrue(process, PROCESS_IS_VALID)
 
-        listener = lldb.debugger.GetListener()
+        listener = self.dbg.GetListener()
         broadcaster = process.GetBroadcaster()
         rc = broadcaster.AddListener(listener, lldb.SBProcess.eBroadcastBitStateChanged)
         self.assertTrue(rc != 0, "Unable to add listener to process")




More information about the lldb-commits mailing list