[Lldb-commits] [PATCH] D61072: [lldb] [lit] Add tests for reading new x86_64 registers

Michał Górny via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Apr 25 09:13:53 PDT 2019


mgorny added inline comments.


================
Comment at: lldb/lit/Register/Inputs/x86-64-read.cpp:8
+int main() {
+  uint64_t r8 = 0x0102030405060708;
+  uint64_t r9 = 0x1112131415161718;
----------------
labath wrote:
> what do you think about including r0-r7 too? They're of different sizes on x86 vs x86_64, so I don't think we'll be able to have a single test which would work on both arches.
Do you mean RAX, RBX, etc.? Yeah, I suppose I can do that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61072/new/

https://reviews.llvm.org/D61072





More information about the lldb-commits mailing list