[Lldb-commits] [PATCH] D61090: [SBHostOS} Remove getting the python script interpreter path
Davide Italiano via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Apr 24 14:54:27 PDT 2019
davide added a comment.
While the intentions of exposing this are good, the implementation leaks too many details. In fact, there shouldn't be anything outside of ScriptInterpreter guarded by `LLDB_DISABLE_PYTHON`.
You might want also to realize that having `ePathTypePythonDir` goes against the whole notion of a generic pluggable interpreter.
Imagine tomorrow somebody wants to implement support for another language, what would this call return for it?
If we really want to keep supporting this, maybe the ScriptInterpreter should have a base method that we can override? Still sounds a little bizarre to me because it's really hard to generalize the notion of `PythonDir` for any other language whatsoever.
CHANGES SINCE LAST ACTION
More information about the lldb-commits