[Lldb-commits] [PATCH] D59991: [Linux/x86] Fix writing of non-gpr registers on newer processors
Joseph Tremoulet via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Apr 23 09:06:55 PDT 2019
JosephTremoulet added a comment.
In D59991#1475694 <https://reviews.llvm.org/D59991#1475694>, @labath wrote:
> gcc-5.4 technically supported, so we can try to make things work for you. I'd be best if you can create a patch that will make things work for you (since it's kinda hard for me to test that). Or at least, can you paste the contents of your cpuid.h somewhere?
Ok. I'd be happy to put a patch together... is there an existing pattern for this sort of thing that I should follow? E.g. define a helper llvm::get_cpuid_count function somewhere, similar to STLExtras? Or just define it in this file? Looking at the implementation of __get_cpuid_count in libc++, it's pretty short, my instinct would be to just inline that logic into the callsite here... LMK if there's a preferred approach.
CHANGES SINCE LAST ACTION
More information about the lldb-commits