[Lldb-commits] [lldb] r358525 - [debugserver] Relax the codesigning identity check

[Frederic Riss via lldb-commits]

Author: friss
Date: Tue Apr 16 13:54:42 2019
New Revision: 358525

URL: http://llvm.org/viewvc/llvm-project?rev=358525&view=rev
Log:
[debugserver] Relax the codesigning identity check

In an effort to help new LLDB developers, we added checks and messaging around
the selection of your codesigning identity on macOS. While helpful, it is not
actually correct. It's perfectly valid to codesign with an identity that is
not named lldb_codesign. Currently this fails the build.

This patch keeps a warning that informs developers how to setup lldb_codesign
and how to pass it to cmake, but it allows the build to proceed with a
different identity.

Modified:
    lldb/trunk/tools/debugserver/source/CMakeLists.txt

Modified: lldb/trunk/tools/debugserver/source/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/CMakeLists.txt?rev=358525&r1=358524&r2=358525&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/CMakeLists.txt (original)
+++ lldb/trunk/tools/debugserver/source/CMakeLists.txt Tue Apr 16 13:54:42 2019
@@ -93,18 +93,14 @@ elseif(NOT LLDB_NO_DEBUGSERVER)
   # Default case: on Darwin we need the right code signing ID.
   # See lldb/docs/code-signing.txt for details.
   if(CMAKE_HOST_APPLE AND NOT LLVM_CODESIGNING_IDENTITY STREQUAL "lldb_codesign")
-    set(problem "Cannot code sign debugserver with LLVM_CODESIGNING_IDENTITY '${LLVM_CODESIGNING_IDENTITY}'.")
-    set(advice "Pass -DLLDB_CODESIGN_IDENTITY=lldb_codesign to override the LLVM value for debugserver.")
-    if(system_debugserver)
-      set(effect "Will fall back to system's debugserver.")
-      set(use_system_debugserver ON)
-    else()
-      set(effect "debugserver will not be available.")
-    endif()
-    message(WARNING "${problem} ${effect} ${advice}")
-  else()
-    set(build_and_sign_debugserver ON)
+    message(WARNING "Codesigning debugserver with identity ${LLVM_CODESIGNING_IDENTITY}. "
+                    "The usual setup uses the \"lldb_codesign\" identity created with "
+                    "scripts/macos-setup-codesign.sh. As a result your debugserver might "
+                    "not be able to attach to processes.\n"
+                    "Pass -DLLDB_CODESIGN_IDENTITY=lldb_codesign to use the development "
+                    "signing identity.")
   endif()
+  set(build_and_sign_debugserver ON)
 endif()
 
 # TODO: We don't use the $<TARGET_FILE:debugserver> generator expression here,