[Lldb-commits] [PATCH] D60410: PDBFPO: Improvements to the AST visitor

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Apr 11 09:05:20 PDT 2019


labath updated this revision to Diff 194705.
labath added a comment.

After trying to use this in new code, I realized that the CRTP is not really
needed for what I am trying to achieve here. The same can be achieved through
more standard virtual functions.

This updates the patch to use virtual functions, which may be 0.01% slower, but
that certainly does not matter here. I also rename the function arguments from
"node" to more descriptive names.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60410/new/

https://reviews.llvm.org/D60410

Files:
  source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60410.194705.patch
Type: text/x-patch
Size: 14778 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190411/66552e43/attachment.bin>


More information about the lldb-commits mailing list