[Lldb-commits] [PATCH] D59537: Instantiate 'std' templates explicitly in the expression evaluator

Shafik Yaghmour via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Apr 9 13:27:27 PDT 2019


shafik added inline comments.


================
Comment at: lldb/include/lldb/Symbol/ClangASTImporter.h:247
 
+    struct StdModuleScope {
+      StdModuleHandler m_handler;
----------------
aprantl wrote:
> Can you add a `///` one-liner for this class?
This definitely needs a description, it took me a bit to understand what its purpose was and it feels a little subtle. Something along the lines of "RAII class to ensure that the StdModuleHandler is properly set and unset...." 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59537/new/

https://reviews.llvm.org/D59537





More information about the lldb-commits mailing list