[Lldb-commits] [PATCH] D60468: Lock accesses to OptionValueFileSpecList objects

Frederic Riss via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Apr 9 09:35:34 PDT 2019


friss added a comment.

In D60468#1460013 <https://reviews.llvm.org/D60468#1460013>, @clayborg wrote:

> Almost seems like we can build the mutex into the base class OptionValue as we need general threaded protection for every setting. They any function that gets or sets the value should be able to protect itself using the base mutex


If we generalize this to most other properties, then this would make sense. Note that all properties that store very simple types don't need this, as they don't risk being accessed in a broken state.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60468/new/

https://reviews.llvm.org/D60468





More information about the lldb-commits mailing list