[Lldb-commits] [lldb] r357131 - Teach TypeSystem about PDBASTParser

Nathan Lanza via lldb-commits lldb-commits at lists.llvm.org
Wed Mar 27 16:00:48 PDT 2019


Author: lanza
Date: Wed Mar 27 16:00:47 2019
New Revision: 357131

URL: http://llvm.org/viewvc/llvm-project?rev=357131&view=rev
Log:
Teach TypeSystem about PDBASTParser

Currently, only ClangASTContext knows about PDBASTParser. Eventually
we want the TypeSystem to have getters/setters for the base parser
and then have the TypeSystem subclasses know about the proper
PDBASTParser subclasses. This is similar to how DWARFASTParsers work.

Modified:
    lldb/trunk/include/lldb/Symbol/ClangASTContext.h
    lldb/trunk/include/lldb/Symbol/TypeSystem.h

Modified: lldb/trunk/include/lldb/Symbol/ClangASTContext.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Symbol/ClangASTContext.h?rev=357131&r1=357130&r2=357131&view=diff
==============================================================================
--- lldb/trunk/include/lldb/Symbol/ClangASTContext.h (original)
+++ lldb/trunk/include/lldb/Symbol/ClangASTContext.h Wed Mar 27 16:00:47 2019
@@ -454,7 +454,7 @@ public:
   // TypeSystem methods
   //------------------------------------------------------------------
   DWARFASTParser *GetDWARFParser() override;
-  PDBASTParser *GetPDBParser();
+  PDBASTParser *GetPDBParser() override;
 
   //------------------------------------------------------------------
   // ClangASTContext callbacks for external source lookups.

Modified: lldb/trunk/include/lldb/Symbol/TypeSystem.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Symbol/TypeSystem.h?rev=357131&r1=357130&r2=357131&view=diff
==============================================================================
--- lldb/trunk/include/lldb/Symbol/TypeSystem.h (original)
+++ lldb/trunk/include/lldb/Symbol/TypeSystem.h Wed Mar 27 16:00:47 2019
@@ -25,6 +25,7 @@
 
 class DWARFDIE;
 class DWARFASTParser;
+class PDBASTParser;
 
 namespace lldb_private {
 
@@ -91,6 +92,7 @@ public:
   virtual void Finalize() {}
 
   virtual DWARFASTParser *GetDWARFParser() { return nullptr; }
+  virtual PDBASTParser *GetPDBParser() { return nullptr; }
 
   virtual SymbolFile *GetSymbolFile() const { return m_sym_file; }
 




More information about the lldb-commits mailing list