[Lldb-commits] [PATCH] D59911: Don't abort() in lldb_assert and document why.

Adrian Prantl via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Mar 29 09:00:27 PDT 2019


aprantl added a comment.

Another problem with `lldb_assert()` is that in its current form it prints to stderr, which AFAIK is not even visible when LLDB is invoked from an IDE like Xcode.

I like Pavel's suggestion of having a report_once function.

It looks like everybody seems to agree that lldb_assert has some useful ideas but is flawed in its implementation. I'm going to land this patch and we can continue improving or building a replacement for lldb_assert independently from this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59911/new/

https://reviews.llvm.org/D59911





More information about the lldb-commits mailing list