[Lldb-commits] [PATCH] D59957: Convert = operators that take object mutexes to the multi-lock version of std::lock

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Mar 28 13:01:00 PDT 2019


jingham created this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

I made a copy-paste error copying the ModuleList trick for avoiding priority inversion in taking the lhs & rhs mutexes.  Pavel pointed out you can use the std::lock(lock1, lock2) form to do this more cleanly.  I fixed the one I got wrong and I think I found all the other places doing this (or just locking both mutexes) and replaced them with this form.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D59957

Files:
  include/lldb/Core/ModuleSpec.h
  include/lldb/Utility/StreamTee.h
  source/Breakpoint/BreakpointLocationCollection.cpp
  source/Core/ModuleList.cpp
  source/Target/SectionLoadList.cpp
  source/Target/ThreadList.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59957.192704.patch
Type: text/x-patch
Size: 5715 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190328/85f6be68/attachment.bin>


More information about the lldb-commits mailing list