[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

Wed Mar 27 08:20:23 PDT 2019

tatyana-krasnukha added a comment.

In D55718#1443415 <https://reviews.llvm.org/D55718#1443415>, @jasonmolenda wrote:

> Back in 2015 I added some code in r247121 that would fill in eh_frame and dwarf register numbers from the ABI plugin if the remote stub didn't provide them in ProcessGDBRemote's AugmentRegisterInfoViaABI.  It might be better for ARC to hardcode these generic register additions some place like that.

Latest versions of this patch use `AugmentRegisterInfoViaABI` to adjust eh_frame/dwarf numbers. But I still need to examine configuration registers to determine current configuration of the ARC processor. The Architecture plug-in would be a better place to do this, however it need to obtain register values when `RegisterContext` doesn't exist. It is not possible for now. As I see it, we should rather make `Process` able to read "fixed" (context-independent) registers even when there is no threads yet. Also the `RegisterContext` might avoid updating those registers on every stop. Does someone think this would be a good idea? Anyway, it ought to be a separate differential revision, I think.

Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55718/new/

https://reviews.llvm.org/D55718