[Lldb-commits] [PATCH] D59819: Make operator==s consistent between c++ and python APIs

[Pavel Labath via Phabricator via lldb-commits]

labath marked 2 inline comments as done.
labath added inline comments.


================
Comment at: include/lldb/API/SBAddress.h:34-37
+  // operator== is a free function
+
+  bool operator!=(const SBAddress &rhs) const;
+
----------------
A different solution to this could be to still keep the free operator== defined, but do not expose it in the header. Then we could define a member operator==, without things being ambiguous. The people who build against old headers will still find the free operator== in the shared library, and people who use the new headers will start using the member operator==.


================
Comment at: source/API/SBAddress.cpp:66-70
 bool lldb::operator==(const SBAddress &lhs, const SBAddress &rhs) {
   if (lhs.IsValid() && rhs.IsValid())
     return lhs.ref() == rhs.ref();
   return false;
 }
----------------
@JDevlieghere: you might be interested to know that this function is not intercepted by the api recorder. (This could be another argument for the "private free operator==" idea I mention above, as it would mean we don't need to add special code to intercept free functions.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59819/new/

https://reviews.llvm.org/D59819