[Lldb-commits] [PATCH] D59681: Update the lldb driver to support the -O and -S options when passing --repl

[Nathan Hawes via Phabricator via lldb-commits]

nathawes marked an inline comment as done.
nathawes added inline comments.


================
Comment at: lldb/lit/Driver/TestRepl.test:2
+# RUN: echo ':quit' | %lldb -x --repl -O 'expr 42' -S %S/Inputs/Print2.in -o 'expr something invalid' -s %s 2>&1 | FileCheck %s
+# CHECK: warning: commands specified to run after file load (via -o or -s) are ignored in REPL mode
+# CHECK: (int) $0 = 42
----------------
aprantl wrote:
> I think the REPL by default echoes all comments, so this may actually be matching the comment in the input file rather than the warning?
> 
> I think this should do the trick:
> 
> `# CHECK: {{w}}arning: commands specified to run after file load (via -o or -s) are ignored in REPL mode`
Good catch! I think this patch actually changes that behavior because the %lldb expansion includes `-S path/to/lldb/lit/lit-lldb-init` which sets echo-comment-commands false and isn't ignored anymore, but if we ever regress and stop respecting `-S` this test would still pass...


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59681/new/

https://reviews.llvm.org/D59681