[Lldb-commits] [PATCH] D59498: [DWARF] Remove a couple of log statements

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Mar 18 14:19:06 PDT 2019


JDevlieghere accepted this revision.
JDevlieghere added a subscriber: davide.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

In D59498#1433421 <https://reviews.llvm.org/D59498#1433421>, @zturner wrote:

> In all cases, I think the question worth asking is not "could it be used for X", but rather "how often is it actually used for X".  Otherwise, it's just technical debt IMO.  There's a lot of things that are possible in theory, but unless it exhibits value in practice, YAGNI.


I strongly agree with this. Unless this is something we want to know from a user, we can probably get this information by setting a breakpoint.

> This is bad advertising. It's like a butcher that sells vegan meat.  (Quote @davide)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59498/new/

https://reviews.llvm.org/D59498





More information about the lldb-commits mailing list