[Lldb-commits] [lldb] r356378 - Fix some "variable 'foo' set but not used" warnings

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Mon Mar 18 09:04:47 PDT 2019


Author: labath
Date: Mon Mar 18 09:04:46 2019
New Revision: 356378

URL: http://llvm.org/viewvc/llvm-project?rev=356378&view=rev
Log:
Fix some "variable 'foo' set but not used" warnings

gcc-8 diagnoses these.

Modified:
    lldb/trunk/source/API/SBFrame.cpp
    lldb/trunk/source/API/SBTarget.cpp

Modified: lldb/trunk/source/API/SBFrame.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/API/SBFrame.cpp?rev=356378&r1=356377&r2=356378&view=diff
==============================================================================
--- lldb/trunk/source/API/SBFrame.cpp (original)
+++ lldb/trunk/source/API/SBFrame.cpp Mon Mar 18 09:04:46 2019
@@ -1084,7 +1084,6 @@ lldb::SBValue SBFrame::EvaluateExpressio
   Log *expr_log(GetLogIfAllCategoriesSet(LIBLLDB_LOG_EXPRESSIONS));
 #endif
 
-  ExpressionResults exe_results = eExpressionSetupError;
   SBValue expr_result;
 
   if (expr == nullptr || expr[0] == '\0') {
@@ -1117,8 +1116,7 @@ lldb::SBValue SBFrame::EvaluateExpressio
               frame_description.GetData());
         }
 
-        exe_results = target->EvaluateExpression(expr, frame, expr_value_sp,
-                                                 options.ref());
+        target->EvaluateExpression(expr, frame, expr_value_sp, options.ref());
         expr_result.SetSP(expr_value_sp, options.GetFetchDynamicValue());
       }
     }

Modified: lldb/trunk/source/API/SBTarget.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/API/SBTarget.cpp?rev=356378&r1=356377&r2=356378&view=diff
==============================================================================
--- lldb/trunk/source/API/SBTarget.cpp (original)
+++ lldb/trunk/source/API/SBTarget.cpp Mon Mar 18 09:04:46 2019
@@ -2356,7 +2356,6 @@ lldb::SBValue SBTarget::EvaluateExpressi
   Log *expr_log(GetLogIfAllCategoriesSet(LIBLLDB_LOG_EXPRESSIONS));
 #endif
   SBValue expr_result;
-  ExpressionResults exe_results = eExpressionSetupError;
   ValueObjectSP expr_value_sp;
   TargetSP target_sp(GetSP());
   StackFrame *frame = NULL;
@@ -2383,8 +2382,7 @@ lldb::SBValue SBTarget::EvaluateExpressi
           expr, options.GetFetchDynamicValue(),
           frame_description.GetString().str().c_str());
 #endif
-      exe_results =
-          target->EvaluateExpression(expr, frame, expr_value_sp, options.ref());
+      target->EvaluateExpression(expr, frame, expr_value_sp, options.ref());
 
       expr_result.SetSP(expr_value_sp, options.GetFetchDynamicValue());
     }




More information about the lldb-commits mailing list