[Lldb-commits] [PATCH] D59427: [lldb] [API] Split SBRegistry into smaller files

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Fri Mar 15 13:51:46 PDT 2019


That being said, the tool won't generate register macros when the
corresponding record macro is already in place, so the initial move would
have to be done by hand.

On Fri, Mar 15, 2019 at 1:47 PM Jonas Devlieghere <jonas at devlieghere.com>
wrote:

> They actually are auto generated, using the lldb-inst tool. Currently the
> record macros are inserted in place, while the register macros are dumped
> to stdout. I didn’t want to add too much complexity. However, it would be
> really easy to just dump the register macros in the file as well.
>
> On Fri, Mar 15, 2019 at 13:44 Zachary Turner via Phabricator <
> reviews at reviews.llvm.org> wrote:
>
>> zturner added a comment.
>>
>> Or better yet, make it a static method on each SB class.  E.g.
>> `SBTarget::InitializeReproducerRegistry();` etc, one for each class.
>>
>> Random thought, but this all seems like a very high maintenance strategy,
>> having to manually update this registry when methods are added or removed.
>> Did you ever consider auto-generating them by parsing the SWIG?
>>
>>
>> Repository:
>>   rLLDB LLDB
>>
>> CHANGES SINCE LAST ACTION
>>   https://reviews.llvm.org/D59427/new/
>>
>> https://reviews.llvm.org/D59427
>>
>>
>>
>> --
> Sent from my iPhone
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190315/b92d6782/attachment.html>


More information about the lldb-commits mailing list