[Lldb-commits] [PATCH] D59291: Add basic minidump support to obj2yaml
James Henderson via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Mar 13 06:53:51 PDT 2019
jhenderson added a comment.
In D59291#1427349 <https://reviews.llvm.org/D59291#1427349>, @labath wrote:
> So, if we want to split this up more, I can propose the following:
> - split off the BinaryFormat&Object changes into a separate patch, test it with some inline C char arrays
> - write the yaml2obj equivalent of this patch, test it via unit tests and the Object minidump reader
> - finally, come back to this patch (obj2yaml), test it via `yamlobj|obj2yaml` round-tripping
> What do you think?
This sounds like a reasonable breakdown to me. Another possibility for testing yaml2obj is some form of minidump support in llvm-readobj or similar, which uses the Object minidump reader to verify things in lit tests.
CHANGES SINCE LAST ACTION
More information about the lldb-commits