[Lldb-commits] [PATCH] D59276: Delete dead code
Zachary Turner via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Mar 12 16:31:04 PDT 2019
zturner added a comment.
In D59276#1426972 <https://reviews.llvm.org/D59276#1426972>, @aprantl wrote:
> One one hand this seems fine to remove, but on the other hand — won't these functions come in handy to compare and debug differences between the LLDB and LLVM DWARF parsers, while we are switching over?
Maybe, but I'm not sure how useful it will actually be in practice to compare dump output that way. I feel like if we successfully parse the DWARF using LLVM's parser, and no tests on either side regress in the process, then it is probably sufficient to say that things worked.
Can you imagine a scenario where the two outputs meaningfully differ but the test suites passed anyway?
CHANGES SINCE LAST ACTION
More information about the lldb-commits