[Lldb-commits] [PATCH] D59235: Remove Support for DWARF64

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Mar 11 16:21:39 PDT 2019

clayborg added a comment.

My main concern with the LLVM DWARF parser is all of the asserts in the code. If you attempt to use a DWARFDIE without first checking it for validity, it will crash on you instead of returning a good error or default value. That makes me really nervous as we shouldn't just crash the debugger. The switching over won't be too hard, just the fallout from the LLDB versions of the class that do error checking and return good error/default values and LLVM being very strict.



More information about the lldb-commits mailing list