[Lldb-commits] [PATCH] D59158: Break cycle lldb/Commands [3->] lldb/Expression [1->] lldb/Commands
Jim Ingham via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Mar 11 14:50:11 PDT 2019
jingham added a comment.
It's a little weird that the CommandObjectExpression is telling the REPL what its options should be, it would be more natural to go the other way. Maybe have the repl_sp provide a properly set up set of EvaluateExpressionOptions and then copy them over to this CommandObjectExpression execution?
Also, as is GetExprOptions is not a very descriptive name for something that's specifically setting up Command & EvaluateExpressionOptions for the REPL.
CHANGES SINCE LAST ACTION
More information about the lldb-commits