[Lldb-commits] [PATCH] D59198: Correctly look up declarations in inline namespaces

[Adrian Prantl via Phabricator via lldb-commits]

aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/source/Symbol/ClangASTContext.cpp:10269
+    void *opaque_decl_ctx, void *other_opaque_decl_ctx) {
+  auto decl_ctx = (clang::DeclContext *)opaque_decl_ctx;
+  auto other = (clang::DeclContext *)other_opaque_decl_ctx;
----------------
`auto *`


================
Comment at: lldb/source/Symbol/CompilerDeclContext.cpp:68
+  // over the type system to know that the lookup is identical.
+  if (*this == other)
+    return true;
----------------
would `if (this == &other)` also work?


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59198/new/

https://reviews.llvm.org/D59198