[Lldb-commits] [PATCH] D59158: Break cycle lldb/Commands [3->] lldb/Expression [1->] lldb/Commands
Jonas Devlieghere via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Mar 8 15:48:11 PST 2019
JDevlieghere added a comment.
In D59158#1423483 <https://reviews.llvm.org/D59158#1423483>, @zturner wrote:
> Interesting, I had looked at fixing this one once before but I didn't realize we had a class named `EvaluateExpressionOptions` that contained just the right set of information, and it felt gross to invent a new one just for this purpose (It's a good thing I didn't too, since we already had another one).
> Can you also update the CMake files? You'll need to update `Expression/CMakeLists.txt` to not pull in `lldbTarget`. I was going to say that you would also need to update `unittests/Expression/CMakeLists.txt`, but it's already not listed, so I guess it's just been relying on linking it transitively.
You mean `lldbCommand`, right? It's already not listed there, and neither in the unittest.
> Do you have the ability to test the build with CMake? If so, could you try `ninja ExpressionTests` and make sure everything still works after removing the link dependcy in `Expression/CMakeLists.txt`?
CHANGES SINCE LAST ACTION
More information about the lldb-commits