[Lldb-commits] [lldb] r355657 - [Reproducers] Mark partial specialization as inline

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Thu Mar 7 16:24:07 PST 2019

Author: jdevlieghere
Date: Thu Mar  7 16:24:06 2019
New Revision: 355657

URL: http://llvm.org/viewvc/llvm-project?rev=355657&view=rev
[Reproducers] Mark partial specialization as inline

The overload and/or template specialization are regular functions and
should be marked inline when implemented in the header. Writing the
previous commit message should've made that obvious but I was already
overthinking it. This will fix the windows bot.


Modified: lldb/trunk/include/lldb/Utility/ReproducerInstrumentation.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Utility/ReproducerInstrumentation.h?rev=355657&r1=355656&r2=355657&view=diff
--- lldb/trunk/include/lldb/Utility/ReproducerInstrumentation.h (original)
+++ lldb/trunk/include/lldb/Utility/ReproducerInstrumentation.h Thu Mar  7 16:24:06 2019
@@ -37,7 +37,8 @@ void log_append(llvm::raw_string_ostream
   ss << t;
-template <> void log_append<char>(llvm::raw_string_ostream &ss, const char *t) {
+inline template <>
+void log_append<char>(llvm::raw_string_ostream &ss, const char *t) {
   ss << t;

More information about the lldb-commits mailing list