[Lldb-commits] [PATCH] D57475: [Reproducers] Add SBReproducer macros

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Thu Mar 7 09:12:53 PST 2019

Yes, I think that makes sense. I'll remove the register macro for now,
which initializes the types. The record macro I'll leave in place to ensure
the toggling between boundaries doesn't get affected by this. The "nice"
side effect is that it will trigger an assertion during replay, which
hopefully makes this easier to triage down the line.

On Thu, Mar 7, 2019 at 12:52 AM Pavel Labath via Phabricator <
reviews at reviews.llvm.org> wrote:

> labath added a comment.
> Jonas, would it be possible to just not intercept the functions which work
> with thread IDs and similar stuff (an all OSs)?
> Using the naive serialization approach will not be correct for these, even
> if the types happen to be implemented as primitive types (most likely we
> will need some runtime remapping of thread id's or something), so I am
> hoping it would not affect the ability to record&replay the recordings
> which don't use these functions.
> Repository:
>   https://reviews.llvm.org/D57475/new/
> https://reviews.llvm.org/D57475
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190307/bc7a7b0a/attachment-0001.html>

More information about the lldb-commits mailing list