[Lldb-commits] [PATCH] D55626: [Reproducers] Add tests for functionality

[Adrian Prantl via Phabricator via lldb-commits]

aprantl requested changes to this revision.
aprantl added inline comments.
This revision now requires changes to proceed.
Herald added a subscriber: jdoerfert.


================
Comment at: lit/Reproducer/Functionalities/Inputs/foo.cpp:3
+public:
+  Foo(int i, double d) : m_i(i), m_d(d){};
+
----------------
clang-format?


================
Comment at: lit/Reproducer/Functionalities/TestImagineList.test:8
+
+# RUN: rm -rf %T/imagelist
+# RUN: rm -rf %t.txt
----------------
You're not supposed to use %T since it;'s not unique. Instead do
```
# RUN: rm -rf %t && mkdir %t
# RUN: rm -rf %t/imagelist
```


================
Comment at: lit/Reproducer/Functionalities/TestImagineList.test:17
+
+# RUN: rm -rf
+
----------------
really? ;-)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55626/new/

https://reviews.llvm.org/D55626