[Lldb-commits] [PATCH] D58930: Add XCOFF triple object format type for AIX
Sean Fertile via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Mar 6 10:04:13 PST 2019
sfertile added inline comments.
Comment at: llvm/lib/MC/MCContext.cpp:165
+ case MCObjectFileInfo::IsXCOFF:
+ // TODO: Need to implement class MCSymbolXCOFF.
> JDevlieghere wrote:
> > See previous comment.
> It is certain that we will need MCSymbolXCOFF. But before we run into cases where we actually need a MCSymbolXCOFF, we could use the generic MCSymbol first for XCOFF platform. So I don't want to put a llvm_unreachable here.
Would it make sense to add an llvm_unreachable now, and the first patch that actually uses an MCSymbol stubs out the class and removes the unreachable?
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits