[Lldb-commits] [lldb] r355449 - Revert logging addition to SBCompileUnit::GetNumLineEntries,

[Davide Italiano via lldb-commits]

You should check whether log is enabled, I think.

On Tue, Mar 5, 2019 at 2:16 PM Jason Molenda via lldb-commits
<lldb-commits at lists.llvm.org> wrote:
>
> Author: jmolenda
> Date: Tue Mar  5 14:17:47 2019
> New Revision: 355449
>
> URL: http://llvm.org/viewvc/llvm-project?rev=355449&view=rev
> Log:
> Revert logging addition to SBCompileUnit::GetNumLineEntries,
> causing lldb-mi testsuite failures?
>
> Modified:
>     lldb/trunk/source/API/SBCompileUnit.cpp
>
> Modified: lldb/trunk/source/API/SBCompileUnit.cpp
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/API/SBCompileUnit.cpp?rev=355449&r1=355448&r2=355449&view=diff
> ==============================================================================
> --- lldb/trunk/source/API/SBCompileUnit.cpp (original)
> +++ lldb/trunk/source/API/SBCompileUnit.cpp Tue Mar  5 14:17:47 2019
> @@ -43,15 +43,10 @@ SBFileSpec SBCompileUnit::GetFileSpec()
>  }
>
>  uint32_t SBCompileUnit::GetNumLineEntries() const {
> -  Log *log(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_API));
>    if (m_opaque_ptr) {
>      LineTable *line_table = m_opaque_ptr->GetLineTable();
> -    if (line_table) {
> -      log->Printf("SBCompileUnit(%p)::GetNumLineEntries() => %d",
> -                static_cast<void *>(m_opaque_ptr),
> -                (int)line_table->GetSize());
> +    if (line_table)
>        return line_table->GetSize();
> -    }
>    }
>    return 0;
>  }
>
>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits