[Lldb-commits] [PATCH] D58972: Introduce the "Formats" module and move LinuxProcMaps parser to it

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Mar 5 12:58:32 PST 2019

JDevlieghere added a comment.

In D58972#1418931 <https://reviews.llvm.org/D58972#1418931>, @labath wrote:

> FileFormats wouldn't be generic enough to capture the gdb-remote or debug-info-server protocol code. However, even calling gdb-remote protocol a "format" is still a bit of a stretch. I think there is enough similarity between gdb-remote and minidump code for them to be in the same module (both convert some (and often the same) data structures into some (file or wire) format), but they're also sufficiently different for them to live in different places. So yeah, if we want the protocol code to live in a different library (Protocols ?), then FileFormats is a better name here.

I was going to propose `Protocols` for consideration but that doesn't really work for minidump. Thinking a little about this, `Formats`, although generic, is probably the best.



More information about the lldb-commits mailing list