[Lldb-commits] [PATCH] D58976: Introduce core2yaml tool
Greg Clayton via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Mar 5 09:08:14 PST 2019
clayborg added inline comments.
Comment at: include/lldb/Formats/MinidumpParser.h:105
- lldb::DataBufferSP m_data_sp;
+ llvm::ArrayRef<uint8_t> m_data;
+ const MinidumpHeader *m_header;
I worry about this going stale when the owner of the data lets it go and we crash now that we don't have strong ownership. If this is common in LLVM, then we need to document this in the header file.
CHANGES SINCE LAST ACTION
More information about the lldb-commits