[Lldb-commits] [PATCH] D58962: Sanity check --max-gdbserver-port

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Mar 5 08:48:10 PST 2019


labath added inline comments.


================
Comment at: lldb/lit/helper/toolchain.py:19
     dsargs = [] if platform.system() in ['Darwin'] else ['gdbserver']
+    psargs = ['FIXME'] if platform.system() in ['Darwin'] else ['platform']
     lldbmi = ToolSubst('%lldbmi',
----------------
For the "platform" mode, Darwin uses lldb-server like other platforms. So this should just be "lldb-server platform" unconditionally.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58962/new/

https://reviews.llvm.org/D58962





More information about the lldb-commits mailing list